Skip to content

Conversation

@gliptak
Copy link

@gliptak gliptak commented May 24, 2025

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Author

gliptak commented May 28, 2025

@rvantonder please review

1 similar comment
@gliptak
Copy link
Author

gliptak commented Jun 22, 2025

@rvantonder please review

@gliptak
Copy link
Author

gliptak commented Jul 17, 2025

@rvantonder have you had a chance to work this?

@rvantonder
Copy link
Member

Hey @gliptak I did try I need to update the base image (and push it to docker) and ran into an issue. I'll check in again in some time this week. I wish I could do things a bit faster, busy!

@gliptak
Copy link
Author

gliptak commented Sep 30, 2025

@rvantonder please provide next steps

@rvantonder
Copy link
Member

rvantonder commented Oct 3, 2025

Thanks @gliptak.

I can add this but it's just going to build the base image and not push it to Docker, which is what's really needed to do an actual Docker release. It might help flag issues with e.g., #379 -- for that I still had issues building locally, and it's dependent on pushing up the base dep image for Docker. So even if this GH build succeeds, I still need it to build manually and then push the image upstream (I don't want to have to manage secrets with GH build to push to Docker on every push, that's kind of too much hassle for me to maintain--the Dockerfile is there as a DIY solution if folks want to use Docker, so it is best if I just update it manually locally with my credentials).

Let me see if I can merge #379, I will try build the base image and push up to Docker first.

@gliptak
Copy link
Author

gliptak commented Oct 3, 2025

thank you @rvantonder consider publishing to ghcr.io which doesn't require additional credentials (like https://github.com/gliptak/aws-cdk-python/pkgs/container/aws-cdk-python) I'm open to submit a followup PR implementing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants