Skip to content

record audio node #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2025
Merged

record audio node #8716

merged 2 commits into from
Aug 16, 2025

Conversation

jtydhr88
Copy link
Contributor

@jtydhr88 jtydhr88 commented Jun 28, 2025 •
edited by christian-byrne
Loading

@jtydhr88 jtydhr88 mentioned this pull request Jun 28, 2025
Merged
guill
guill reviewed Jun 28, 2025
View reviewed changes
comfy_extras/nodes_audio.py

RETURN_TYPES = ("AUDIO", )
FUNCTION = "load"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for any other reviewers (or future me): Because the uploaded files are named via timestamps by the frontend, an existing uploaded audio file should never be updated. That's why we don't need the IS_CHANGED here.

guill
guill approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@guill guill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jtydhr88
Copy link
Contributor Author

jtydhr88 commented Jul 20, 2025 •
edited
Loading

@OrangeDoro hi, the main issue of your LLM feedback is lacking some context, for this specific case, it could not only consider this single PR, as it also has FE part, the full feature required both BE (this) and FE, such as how we handle upload recoding to temp folder.
Regarding testing, due to we don’t add tests for this file right now, we may add tests later.

BTW, I don’t want to confuse the core team reviewer as we already approve this BE changes, and it is close to merge soon, could you remove your LLM feedback? if you want to share your study, you can email me directly with these information - wswdkt88@gmail.com
Thanks for understanding.

@jtydhr88 jtydhr88 mentioned this pull request Jul 20, 2025
Open
@jtydhr88
Copy link
Contributor Author

@guill @comfyanonymous @christian-byrne As we already merge FE Comfy-Org/ComfyUI_frontend#4289, please make sure we have this PR while include the latest FE

christian-byrne
christian-byrne approved these changes Aug 16, 2025
View reviewed changes
Copy link
Collaborator

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge now, as the frontend support has been added.

@comfyanonymous comfyanonymous merged commit 20a8416 into comfyanonymous:master Aug 16, 2025
5 checks passed
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
@jtydhr88
record audio node (comfyanonymous#8716)
3365421 
* record audio node

* sf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guill guill guill approved these changes

@christian-byrne christian-byrne christian-byrne approved these changes

@yoland68 yoland68 Awaiting requested review from yoland68 yoland68 is a code owner

@robinjhuang robinjhuang Awaiting requested review from robinjhuang robinjhuang is a code owner

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

@ltdrdata ltdrdata Awaiting requested review from ltdrdata ltdrdata is a code owner

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtydhr88 @guill @christian-byrne @comfyanonymous