Skip to content

Use BOOLEAN for the "enable"/"disable" toggle in KSamplerAdvanced #8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neo
Copy link

@neo neo commented Jul 15, 2025

This is to re-open #1087 because I still feel it's better UX, open to suggestions with better labels too.

@neo neo requested a review from comfyanonymous as a code owner July 15, 2025 20:22
@asagi4
Copy link
Contributor

asagi4 commented Jul 15, 2025

You can't do this because it breaks workflows unless there's some fallback from the current text inputs so that they get converted into booleans properly.

@neo
Copy link
Author

neo commented Jul 24, 2025

you're right, this would be a breaking change 😢 is there an established migration strategy that we can maybe adapt? maybe something like #1060 on the front-end side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants