-
Notifications
You must be signed in to change notification settings - Fork 9.7k
async API nodes #9129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
comfyanonymous
merged 10 commits into
comfyanonymous:master
from
bigcat88:feat/async-api-nodes
Aug 8, 2025
Merged
async API nodes #9129
comfyanonymous
merged 10 commits into
comfyanonymous:master
from
bigcat88:feat/async-api-nodes
Aug 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68e6aaa
to
99363dc
Compare
async.execution.480p.movTested with latest frontend. |
Thor-ATX
pushed a commit
to asteriafilmco/ComfyUI
that referenced
this pull request
Aug 11, 2025
…ams-update * commit 'f4231a80b1b904b45ade0def9b37320c4adfe71b': fix(Kling Image API Node): do not pass "image_type" when no image (comfyanonymous#9271) Support SimpleTuner lycoris lora for Qwen-Image (comfyanonymous#9280) Update template & embedded docs (comfyanonymous#9283) remove creation of non-used asyncio_loop (comfyanonymous#9284) Only show feature flags log when verbose. (comfyanonymous#9281) Bump pytorch cuda and rocm versions in readme instructions. (comfyanonymous#9273) Not sure if AMD actually support fp16 acc but it doesn't crash. (comfyanonymous#9258) Users report gfx1201 is buggy on flux with pytorch attention. (comfyanonymous#9244) async API nodes (comfyanonymous#9129) _ui.py import torchaudio safety check (comfyanonymous#9234) Fix RepeatLatentBatch not working on multi dim latents. (comfyanonymous#9227) Update frontend to v1.24.3 (comfyanonymous#9175) Update template to 0.1.52 (comfyanonymous#9206) Fixed an issue where qwenLora could not be loaded properly. (comfyanonymous#9208)
Vander-Bilt
pushed a commit
to Vander-Bilt/ComfyUI
that referenced
this pull request
Aug 26, 2025
* converted API nodes to async * converted BFL API nodes to async * fixed client bug; converted gemini, ideogram, minimax * fixed client bug; converted openai nodes * fixed client bug; converted moonvalley, pika nodes * fixed client bug; converted kling, luma nodes * converted pixverse, rodin nodes * converted tripo, veo2 * converted recraft nodes * add lost log_request_response call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All converted nodes were tested, except for some
Tripo
- they are deactivated in the screenshot, because the nodes require the oldTripo
model, and it is already deprecated in their API.File operations were not converted to async, because it would require connecting the
aiofiles
library - I didn't want to complicate the review of this PR.From what I tested, nodes are normally executed in parallel, only in UI it seems that
SaveImage
sometimes hangs - but this is a deceptive impression, UI simply does not change back what node is executed.Example:
node A -> node B
node C -> node D
if node C is executed much longer than node A, then UI will display that node B has been executed after displaying - and will continue to show it as executed until node C finishes executing;
BFL
Gemini
Ideogram
Kling
Luma
Moonvalley
OpenAI
Pika
PixVerse
Recraft
Rodin
Runway
Stability AI
Tripo
Google Veo2