Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Jul 31, 2025

All converted nodes were tested, except for some Tripo - they are deactivated in the screenshot, because the nodes require the old Tripo model, and it is already deprecated in their API.

File operations were not converted to async, because it would require connecting the aiofiles library - I didn't want to complicate the review of this PR.

From what I tested, nodes are normally executed in parallel, only in UI it seems that SaveImage sometimes hangs - but this is a deceptive impression, UI simply does not change back what node is executed.

Example:
node A -> node B
node C -> node D

if node C is executed much longer than node A, then UI will display that node B has been executed after displaying - and will continue to show it as executed until node C finishes executing;


BFL Screenshot from 2025-08-01 09-23-59
Gemini Screenshot from 2025-08-01 09-44-12
Ideogram Screenshot from 2025-08-01 09-52-52
Kling Screenshot from 2025-08-01 16-23-35
Luma Screenshot from 2025-08-01 16-25-42 Screenshot from 2025-08-01 16-28-23
Moonvalley Screenshot from 2025-08-01 12-33-26
OpenAI Screenshot from 2025-08-01 11-32-00
Pika Screenshot from 2025-08-01 14-29-48
PixVerse Screenshot from 2025-08-01 16-41-56
Recraft Screenshot from 2025-08-01 18-37-23
Rodin Screenshot from 2025-08-01 17-35-18
Runway Screenshot from 2025-07-31 21-07-27
Stability AI Screenshot from 2025-07-31 20-38-55
Tripo Screenshot from 2025-08-01 18-13-07
Google Veo2 Screenshot from 2025-08-01 17-46-28

@bigcat88 bigcat88 force-pushed the feat/async-api-nodes branch from 68e6aaa to 99363dc Compare July 31, 2025 18:08
@bigcat88 bigcat88 marked this pull request as ready for review August 1, 2025 15:39
@robinjhuang
Copy link
Collaborator

async.execution.480p.mov

Tested with latest frontend.

@comfyanonymous comfyanonymous merged commit bf2a1b5 into comfyanonymous:master Aug 8, 2025
6 checks passed
Thor-ATX pushed a commit to asteriafilmco/ComfyUI that referenced this pull request Aug 11, 2025
…ams-update

* commit 'f4231a80b1b904b45ade0def9b37320c4adfe71b':
  fix(Kling Image API Node): do not pass "image_type" when no image (comfyanonymous#9271)
  Support SimpleTuner lycoris lora for Qwen-Image (comfyanonymous#9280)
  Update template & embedded docs (comfyanonymous#9283)
  remove creation of non-used asyncio_loop (comfyanonymous#9284)
  Only show feature flags log when verbose. (comfyanonymous#9281)
  Bump pytorch cuda and rocm versions in readme instructions. (comfyanonymous#9273)
  Not sure if AMD actually support fp16 acc but it doesn't crash. (comfyanonymous#9258)
  Users report gfx1201 is buggy on flux with pytorch attention. (comfyanonymous#9244)
  async API nodes  (comfyanonymous#9129)
  _ui.py import torchaudio safety check (comfyanonymous#9234)
  Fix RepeatLatentBatch not working on multi dim latents. (comfyanonymous#9227)
  Update frontend to v1.24.3 (comfyanonymous#9175)
  Update template to 0.1.52 (comfyanonymous#9206)
  Fixed an issue where qwenLora could not be loaded properly. (comfyanonymous#9208)
@bigcat88 bigcat88 deleted the feat/async-api-nodes branch August 16, 2025 16:59
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
* converted API nodes to async

* converted BFL API nodes to async

* fixed client bug; converted gemini, ideogram, minimax

* fixed client bug; converted openai nodes

* fixed client bug; converted moonvalley, pika nodes

* fixed client bug; converted kling, luma nodes

* converted pixverse, rodin nodes

* converted tripo, veo2

* converted recraft nodes

* add lost log_request_response call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants