Skip to content

Reduce compile-time dependencies #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce compile-time dependencies #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions lib/projections/ecto.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,20 @@ defmodule Commanded.Projections.Ecto do
schema_prefix =
opts[:schema_prefix] || Application.get_env(:commanded_ecto_projections, :schema_prefix)

timeout = opts[:timeout] || :infinity
handler_opts = Keyword.drop(opts, [:repo, :schema_prefix, :timeout])

quote location: :keep do
@behaviour Commanded.Projections.Ecto

@opts unquote(opts)
@repo @opts[:repo] || Application.compile_env(:commanded_ecto_projections, :repo) ||
@repo unquote(opts[:repo]) || Application.compile_env(:commanded_ecto_projections, :repo) ||
raise("Commanded Ecto projections expects :repo to be configured in environment")
@timeout @opts[:timeout] || :infinity

# Pass through any other configuration to the event handler
@handler_opts Keyword.drop(@opts, [:repo, :schema_prefix, :timeout])

unquote(__include_schema_prefix__(schema_prefix))
unquote(__include_projection_version_schema__())

use Ecto.Schema
use Commanded.Event.Handler, @handler_opts
use Commanded.Event.Handler, unquote(handler_opts)

import Ecto.Changeset
import Ecto.Query
Expand Down Expand Up @@ -106,7 +104,7 @@ defmodule Commanded.Projections.Ecto do
end

defp transaction(%Ecto.Multi{} = multi) do
@repo.transaction(multi, timeout: @timeout, pool_timeout: @timeout)
@repo.transaction(multi, timeout: unquote(timeout), pool_timeout: unquote(timeout))
end

defoverridable schema_prefix: 1, schema_prefix: 2
Expand Down