Giving each nav item the same weight so items are aligned properly #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I can see that the items are not centered correctly, but weighting the Box may prevent the titles from appearing correctly. When you try with 4 items after giving weight, you can see that the titles are not fully visible. Already navigation have a problem with long titles. maybe we can think of them together for reach a different solution. |
Contributor
Author
|
maybe pushing the text underneath the icon will allow for more icons to be placed next to each other? |
Owner
|
you are right, I will try to do it. Thanks for pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, items are not always centered correctly. If you have 3 items for example, the middle item's icon is not in the center of the screen when one of the other to tabs are pressed.
This PR fixes that