-
Notifications
You must be signed in to change notification settings - Fork 19
DEVX-658: updating okhttp to v5 #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShipilA
wants to merge
12
commits into
main
Choose a base branch
from
DEVX-658-Update-dependency-com.squareup.okhttp-to-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DEVX-658: updating okhttp to v5 #1006
ShipilA
wants to merge
12
commits into
main
from
DEVX-658-Update-dependency-com.squareup.okhttp-to-v5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenschude
reviewed
Nov 11, 2025
...commercetools-okhttp-client5/src/jmh/java/com/commercetools/http/okhttp4/UnzipBenchmark.java
Outdated
Show resolved
Hide resolved
jenschude
reviewed
Nov 11, 2025
...mmercetools-okhttp-client5/src/main/java/com/commercetools/http/okhttp4/CtOkHttp5Client.java
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
=======================================
Coverage 9.72% 9.72%
Complexity 2077 2077
=======================================
Files 7719 7719
Lines 75937 75937
Branches 348 348
=======================================
Hits 7388 7388
Misses 68355 68355
Partials 194 194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ommercetools/http/okhttp4/CtOkHttp5Client.java Co-authored-by: Jens Schulze <jens.schulze@commercetools.com>
…mmercetools/http/okhttp4/UnzipBenchmark.java Co-authored-by: Jens Schulze <jens.schulze@commercetools.com>
jenschude
approved these changes
Nov 13, 2025
Contributor
jenschude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I updated the settings.gradle and fixed some minor things
…quareup.okhttp-to-v5' into DEVX-658-Update-dependency-com.squareup.okhttp-to-v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added okhttp v5