Fix spurious validation error with scatter+conditionals #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typing related to conditionals should be part of the computed output signature of the step, not added in by the checker. Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
tetron
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
==========================================
- Coverage 66.82% 66.79% -0.03%
==========================================
Files 93 93
Lines 16578 16578
Branches 4404 4404
==========================================
- Hits 11078 11074 -4
- Misses 4361 4364 +3
- Partials 1139 1140 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request introduces 1 alert when merging c4442a8 into 0f70992 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 21da544 into 0f70992 - view on LGTM.com new alerts:
|
mr-c
requested changes
Mar 8, 2022
| for n in range(0, nesting): | ||
| for oparam in outputparms: | ||
| if conditional and n == 0: | ||
| oparam["type"] = ["null"] + cast( |
There was a problem hiding this comment.
Can you add a test case that triggers this line?
There was a problem hiding this comment.
Yes, I was going to add a test, I just wanted to see what the other code checks had to say about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing related to conditionals should be part of the computed output
signature of the step, not added in by the checker.
refs #1639