Skip to content

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 18, 2022

Closes #1765

Unit test fails for main, and passes on this branch. The command from the issue reported also passes on this branch.

Cheers,
-Bruno

@kinow kinow force-pushed the load-schemas-before-print_deps branch 2 times, most recently from be418e9 to 9792f84 Compare November 18, 2022 23:28
@kinow kinow force-pushed the load-schemas-before-print_deps branch from 9792f84 to 2e5cc2e Compare November 18, 2022 23:36
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.06%. Comparing base (67a1808) to head (2e5cc2e).
⚠️ Report is 362 commits behind head on main.

Files with missing lines Patch % Lines
cwltool/main.py 0.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (67a1808) and HEAD (2e5cc2e). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (67a1808) HEAD (2e5cc2e)
14 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1766       +/-   ##
===========================================
- Coverage   82.48%   54.06%   -28.42%     
===========================================
  Files          47       47               
  Lines        8181     8173        -8     
  Branches     2232     2074      -158     
===========================================
- Hits         6748     4419     -2329     
- Misses        939     3218     +2279     
- Partials      494      536       +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kinow
Copy link
Member Author

kinow commented Nov 19, 2022

Hmmm, curious. I saw the tests failing, they are on the same test file that I used.

I picked the first test that failed for me, test_examples.py, test_trick_scandeps. I can confirm the command tested works on main, and fails on my branch.

However, cwltool --validate $file fails on both main and on this branch. So should a CWL file that fails validation, still be used on a unit test? The file is https://github.com/common-workflow-language/cwltool/blob/67a180835c001906cff4086963cd00ee99893498/tests/wf/trick_defaults.cwl

If so I will dig into the issue more and try to extract the part that loads the schemas from the resolve_and_validate_document function 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cwltool --print-deps fails with workflows having namespaced location steps

1 participant