Fix SSH ED25519 key loading #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix SSH ED25519 key loading error by ensuring temporary key files end with newline - Fix cleanup logic using rmdirSync instead of unlinkSync for directories - Add timeout protection to prevent hanging SSH connections - Fix endless status checking loops by removing problematic dependencies - Add debouncing and proper cleanup for status checks - Support file upload without extensions for Windows-generated keys - Improve SSH key type detection for OpenSSH format keys Resolves libcrypto errors and prevents resource leaks in SSH operations.
michelroegl-brunner
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several critical issues with SSH key handling and status checking:
🔧 SSH ED25519 Key Fixes
🔄 Status Check Improvements
🎯 UI/UX Enhancements
🧪 Testing
📁 Files Changed
src/server/ssh-execution-service.js- Fixed key normalization and cleanupsrc/server/ssh-service.js- Fixed key normalizationsrc/server/api/routers/installedScripts.ts- Added timeout protectionsrc/app/_components/InstalledScriptsTab.tsx- Fixed status check loopssrc/app/_components/SSHKeyInput.tsx- Enhanced file upload and key detectionResolves issues with SSH authentication failures and improves overall system stability.