feat: Add prominent LXC creation completion message #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced Terminal component to detect LXC creation scripts - Display prominent block message when LXC creation finishes successfully - Detection based on script path (ct/), container ID, and script name patterns - Maintains backward compatibility for non-LXC scripts - Shows 'LXC CREATION FINISHED' block instead of standard completion message
- Add handleMessage to useEffect dependency array - Move handleMessage function before useEffect and wrap with useCallback - Replace logical OR with proper null check for containerId - Fix React hooks exhaustive-deps warning - Fix TypeScript prefer-nullish-coalescing error
- Clean up merge conflict resolution that left duplicate function - Keep only the properly memoized useCallback version - Fix code duplication issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a prominent completion message for LXC creation scripts to make it more obvious when the LXC creation process has finished successfully.
Changes
Testing
Screenshot
When an LXC creation script finishes successfully, users will now see:
Instead of the standard 'SSH script execution finished with code: 0' message.