Fix terminal colors and functionality issues #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated terminal theme to GitHub Dark with proper ANSI color support - Fixed terminal background and foreground colors for better readability - Removed aggressive CSS overrides that were breaking ANSI color handling - Fixed stop button restarting script execution issue - Added isStopped state to prevent automatic script restart after stop - Improved WebSocket connection stability to prevent duplicate executions - Fixed cursor rendering issues in whiptail sessions - Enhanced terminal styling with proper color palette configuration
- Add install functionality to DownloadedScriptsTab component - Pass onInstallScript prop from main page to DownloadedScriptsTab - Enable terminal display when installing from downloaded scripts tab - Maintain consistency with available scripts tab functionality - Fix missing terminal integration for downloaded script installations
- Add terminal ref to main page for precise scrolling - Update scroll behavior to focus terminal instead of page top - Add mobile-specific offset for better terminal visibility - Remove generic page scroll from ScriptDetailModal - Ensure terminal is properly focused when starting installations on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several terminal-related issues that were affecting the user experience:
🎨 Terminal Color Fixes
🛑 Stop Button Functionality
🛠️ Downloaded Scripts Terminal Integration
🔧 Technical Improvements
Testing
Files Changed
src/app/_components/Terminal.tsx- Terminal component improvementssrc/styles/globals.css- Terminal styling fixessrc/app/page.tsx- Pass install handler to downloaded scriptssrc/app/_components/DownloadedScriptsTab.tsx- Add install functionalityFixes terminal color issues and missing terminal functionality for downloaded scripts.