pyinstaller support added to PipEnv #19030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
reviewed
Oct 3, 2025
davidsanfal
force-pushed
the
feature/pyinstaller-venv
branch
from
237122f to
0501a01
Compare
davidsanfal
force-pushed
the
feature/pyinstaller-venv
branch
from
0501a01 to
57efa02
Compare
czoido
reviewed
Oct 6, 2025
czoido
reviewed
Oct 7, 2025
czoido
reviewed
Oct 16, 2025
memsharded
reviewed
Oct 22, 2025
conan/tools/system/pip_manager.py
Outdated
| def _create_venv(self): | ||
| python_interpreter = self._conanfile.conf.get( | ||
| "tools.system.pipenv:python_interpreter", | ||
| default=shutil.which('python') if platform.system() == "Windows" else shutil.which('python3')) |
There was a problem hiding this comment.
Does the shutil.which() default to find the current interpreter if we are running in a venv already? Or it finds it directly in the system?
There was a problem hiding this comment.
the one inside the virtualenv. But it's a python that's only used during recipe execution. Every time you run it, it's a new environment. In any case, I'm going to add that it gets the real path because in virtualenv python is a symlink.
czoido
reviewed
Oct 27, 2025
czoido
reviewed
Oct 27, 2025
czoido
reviewed
Oct 28, 2025
davidsanfal
force-pushed
the
feature/pyinstaller-venv
branch
from
807d1d9 to
aa63728
Compare
davidsanfal
force-pushed
the
feature/pyinstaller-venv
branch
from
3c45c5a to
4a1d10e
Compare
czoido
reviewed
Oct 29, 2025
czoido
reviewed
Oct 29, 2025
czoido
reviewed
Oct 29, 2025
czoido
reviewed
Oct 29, 2025
czoido
reviewed
Oct 29, 2025
czoido
reviewed
Oct 29, 2025
czoido
approved these changes
Oct 29, 2025
jcar87
approved these changes
Oct 29, 2025
memsharded
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Improved Python virtual environment creation in
PipEnvby using the system-installed interpreter or a user-defined one viatools.system.pipenv:python_interpreter.Docs: conan-io/docs#4291
developbranch, documenting this one.