Add conf to control making .sh and .ps1 env deactivate functionality into in-memory functions instead of files
#19105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: PerseoGI <perseog@jfrog.com>
memsharded
reviewed
Oct 15, 2025
… tests will be added later)
AbrilRBS
changed the title
deactivate functionality into in-memory functions
AbrilRBS
changed the title
deactivate functionality into in-memory functions.sh and .ps1 env deactivate functionality into in-memory functions instead of files
|
Added to 2.22, but this can very well be delayed into 2.23 |
AbrilRBS
commented
Oct 21, 2025
| "tools.apple:enable_visibility": "(boolean) Enable/Disable Visibility Apple Clang flags", | ||
| "tools.env.virtualenv:powershell": "If specified, it generates PowerShell launchers (.ps1). Use this configuration setting the PowerShell executable you want to use (e.g., 'powershell.exe' or 'pwsh'). Setting it to True or False is deprecated as of Conan 2.11.0.", | ||
| "tools.env:dotenv": "(Experimental) Generate dotenv environment files", | ||
| "tools.env:deactivate_function": "(Experimental) Generate a deactivate function instead of a script to unset the environment variables", |
There was a problem hiding this comment.
We need a forward looking conf name so that we can use this for future improvements over the deactivate, not just making it a function
perseoGI
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add opt-in conf to control making
.shand.ps1envdeactivatefunctionality into in-memory functions instead of filesDocs: TODO
This time I paired with @perseoGI to try this approach.
The main lacking feature here is
.batfiles. Those are not made into a function because no such functionality exists there.It's expected that a follow-up PR will have this same conf control
.batfiles being sent into a temp file which is then added to the path to be able to deactivate from everywhere, without cluttering the cwdThe initial push comes from this PR #12914