integrade pmd and fix level 1 of errors #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKulik-sm
commented
Jul 22, 2025
| pmd { | ||
| consoleOutput = true | ||
| ruleSetFiles = files("$rootDir/config/pmd/custom-ruleset.xml") | ||
| rulesMinimumPriority = 1 |
There was a problem hiding this comment.
I hope later to increase it to at least 3
There was a problem hiding this comment.
I also plan to add it to PR pipelines later. Together with spotlessCheck
EugeneKisel-sm
approved these changes
Jul 22, 2025
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
IvanKulik-sm
commented
Jul 23, 2025
| @@ -30,10 +30,9 @@ public class SummaryUtil { | |||
|
|
|||
| private static boolean isSummaryInputOutputJsonSerializationEnabled; | |||
|
|
|||
| private boolean isJsonSerializationEnabled; | |||
|
|
|||
| @Deprecated(forRemoval = true) | |||
| public void init() { | |||
There was a problem hiding this comment.
I’m having trouble understanding the purpose of this class — most of its code seems to be unreachable, and all the booleans are private and unused.
Does anyone happen to remember what the original intention behind this class was, or where it might have been copied from? f4d77a5#diff-cece0d808b9662b571949c1de8b7f123b0f6da6dcea16ac0c46e95a2868cb744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered