Skip to content

Conversation

@IgorChvyrov-sm
Copy link
Contributor

@IgorChvyrov-sm IgorChvyrov-sm commented Oct 23, 2025

Changes:

Added mypy configuration to pyproject.toml
Added mypy check as a pre-commit and CI steps
Implemented all ResourceAPI methods in adapters to provide type hints

Reason:

Improve code quality

@IgorChvyrov-sm IgorChvyrov-sm changed the base branch from main to feature_pre_commit_refactoring October 23, 2025 13:52
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 86.42298% with 104 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...io_client/adapters/api/integration_resource_api.py 75.00% 14 Missing ⚠️
...tor/client/workflow/task/llm_tasks/utils/prompt.py 0.00% 7 Missing ⚠️
...ductor/asyncio_client/workflow/task/switch_task.py 0.00% 4 Missing ⚠️
...t/workflow/task/llm_tasks/utils/embedding_model.py 0.00% 4 Missing ⚠️
...yncio_client/adapters/api/workflow_resource_api.py 92.68% 3 Missing ⚠️
...ent/workflow/task/llm_tasks/llm_index_documents.py 0.00% 3 Missing ⚠️
...lient/workflow/task/llm_tasks/llm_text_complete.py 0.00% 3 Missing ⚠️
src/conductor/client/ai/orchestrator.py 0.00% 3 Missing ⚠️
...onductor/client/event/queue/queue_configuration.py 0.00% 3 Missing ⚠️
src/conductor/client/workflow/task/event_task.py 0.00% 3 Missing ⚠️
... and 36 more
Files with missing lines Coverage Δ
.../asyncio_client/adapters/api/group_resource_api.py 100.00% <100.00%> (ø)
...yncio_client/adapters/api/metadata_resource_api.py 100.00% <100.00%> (ø)
...asyncio_client/adapters/api/schema_resource_api.py 100.00% <100.00%> (ø)
.../conductor/asyncio_client/adapters/api/tags_api.py 100.00% <100.00%> (ø)
...r/asyncio_client/adapters/api/user_resource_api.py 100.00% <100.00%> (ø)
...ctor/asyncio_client/adapters/api_client_adapter.py 95.45% <100.00%> (-0.05%) ⬇️
...r/asyncio_client/adapters/models/action_adapter.py 91.30% <100.00%> (+0.39%) ⬆️
...ctor/asyncio_client/adapters/models/any_adapter.py 71.42% <100.00%> (-1.30%) ⬇️
...ters/models/descriptor_proto_or_builder_adapter.py 88.00% <100.00%> (ø)
...yncio_client/adapters/models/schema_def_adapter.py 100.00% <100.00%> (ø)
... and 130 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IgorChvyrov-sm IgorChvyrov-sm marked this pull request as ready for review October 30, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants