-
Notifications
You must be signed in to change notification settings - Fork 38
Fix: Initialize auth_401_handler before token fetch #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nthmost-orkes
wants to merge
173
commits into
main
Choose a base branch
from
fix/auth-401-handler-latest-before-rollback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and moved shared enums
…s_field_for_event_handler
…nt_handler Tags field for event handler
Bump package version to 1.2.2
v1r3n
requested changes
Nov 12, 2025
Contributor
v1r3n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is on top of the changes we decided to not push to prod anymore.
Author
|
feel free to close
…On Wed, Nov 12, 2025 at 12:22 PM Viren Baraiya ***@***.***> wrote:
***@***.**** requested changes on this pull request.
this is on top of the changes we decided to not push to prod anymore.
—
Reply to this email directly, view it on GitHub
<#362 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXNK2TJ3YIRNPPJCX7W3PQ334OJHFAVCNFSM6AAAAACLWHC4COVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINJVGMZTSMRRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Fixes AttributeError:
'ApiClientAdapter' object has no attribute 'auth_401_handler'Reported Error:
Root Cause
During
ApiClientAdapter.__init__, the code was calling__refresh_auth_token()before initializingauth_401_handler. When authentication settings are configured,__refresh_auth_token()callscall_api('/token'), which requiresauth_401_handlerto exist.Why This Affected Some Deployments But Not Others
This bug only occurs when:
Many deployments didn't hit this because they either:
When Bug Was Introduced
Introduced in commit
1f57c1e7(October 13, 2025) when the 401 exponential backoff feature was added.Changes
auth_401_handlersetup before__ensure_auth_token()call__refresh_auth_token→__ensure_auth_tokenfor clarity (it initializes, doesn't refresh)Testing