Skip to content

Migrate to v2 config #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate to v2 config #181

wants to merge 2 commits into from

Conversation

utamori
Copy link

@utamori utamori commented Aug 6, 2024 •
edited
Loading

I think the old configuration file is unfriendly to people looking for sample code

@emcfarlane
Copy link

@utamori thanks! As a contributor could you please push up with signed commits. You'll need to git commit --ammend -s to sign and force push up the current commit.

nicksnyder
nicksnyder reviewed Aug 6, 2024
View reviewed changes
@utamori
migrate v2 config
f70540b 
Signed-off-by: utamori <mori_yuta@retail-ai.jp>
@utamori utamori force-pushed the feat/migrate-v2-config branch from 37be102 to f70540b Compare August 7, 2024 09:45
@utamori
remove exceptions
9570c5a 
Signed-off-by: utamori <mori_yuta@retail-ai.jp>
@nicksnyder nicksnyder changed the title migrate v2 config Migrate to v2 config Aug 9, 2024
@nicksnyder
Copy link
Member

CI is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicksnyder nicksnyder nicksnyder left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@utamori @emcfarlane @nicksnyder