Refactor/container start test tigron #4675
Open
+40
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tests to use nerdtest.Setup and the Tigron testing framework as per issue containerd#4613. Signed-off-by: Nuwed Munshi <nuwed.munshi@gmail.com>
Updates tests to use nerdtest.Setup and the Tigron as per containerd#4613. Signed-off-by: Nuwed Munshi <nuwed.munshi@gmail.com>
munshinuwed
force-pushed
the
refactor/container-start-test-tigron
branch
from
af55fa9 to
4f574f4
Compare
Author
|
related : #4613 |
haytok
reviewed
Dec 25, 2025
| } | ||
|
|
||
| func TestStartAttach(t *testing.T) { | ||
| if runtime.GOOS == "windows" { |
Contributor
There was a problem hiding this comment.
Could you re-write this part using require.Not(require.Windows), ?
Contributor
|
Hi Nuwed, thank you for creating the PR! In this case, I think it's fine to squash the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.