e2e: add 8-socket 4k-CPU e2e vm and related test for balloons policy #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
force-pushed
the
5e6-e2e-balloons-4kcpu
branch
from
0b5b0bf to
6bf571e
Compare
klihub
reviewed
Nov 21, 2025
test/e2e/policies.test-suite/balloons/s8c4k/test01-sparse-4kcpus/code.var.sh
Outdated
Show resolved
Hide resolved
cpus-present enables creating virtual machines with different numbers of possible and enabled CPUs. CPUs that are possible but not enabled can be hot-plugged when the virtual machine is running. q35 machine, irq split and x2apic are required for hot-plugging CPUs with id >= 256. In case of "separated_output_vars", they are now printed in place of former "CPU:" parameter. This moves Qemu "-cpu" parameter management to topology2qemuopts while it used to be hardcoded "-cpu host" in Vagrantfile.in. Finally, new "SMP:" parameter printing is added for "-smp" parameters. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
marquiz
approved these changes
Dec 12, 2025
Collaborator
marquiz
left a comment
marquiz
left a comment
There was a problem hiding this comment.
Didn't analyze the test case in details but looks good to me
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5e6-e2e-balloons-4kcpu
branch
from
6bf571e to
5a2c5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
to pass the test.
Best reviewed in separate commits. The first commit only refactors (move and rename starting with "nrt-") NRT verification functions from NRT test to a common source file. These functions are then used by the original test script and the test added here.