e2e: support "cxl" in hardware topology (CXL-1) #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpus-present enables creating virtual machines with different numbers of possible and enabled CPUs. CPUs that are possible but not enabled can be hot-plugged when the virtual machine is running. q35 machine, irq split and x2apic are required for hot-plugging CPUs with id >= 256. In case of "separated_output_vars", they are now printed in place of former "CPU:" parameter. This moves Qemu "-cpu" parameter management to topology2qemuopts while it used to be hardcoded "-cpu host" in Vagrantfile.in. Finally, new "SMP:" parameter printing is added for "-smp" parameters. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
- topology2qemuopts converts CXL structures to Qemu PCIe devices and memory backend objects. - Add functions to e2e script API for listing, hotplugging and hotremoving CXL devices. - Move hardcoded Qemu accelerator from Vagrantfile template to topology2qemuopts that already generates Qemu machine parameters. There is no functional change: keep using kvm. However, this enables switching back and forth between "accel=kvm" with "accel=tcg" in generated Vagrantfile more cleanly than between "-enable-kvm" and "". While "accel=tcg" is needed to actually use CXL memory in vm, it is most likely faster to do test setup first with kvm, and finally reboot to tcg once the vm has been fully prepared for such a test. - Use explicitly specified PCIe root port for Qemu disk in Vagrantfile to avoid errors when CXL PCIe devices are added. - Fix a bug in SEPARATED_OUTPUT_VARS=1 output, where an empty deviceparams or objectparams list caused extra ", ," in output leading to errors in Vagrantfile. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #587.