Skip to content

Conversation

@brianheineman
Copy link

Add binary release support for aarch64-unknown-linux-gnu. The version of cargo-dist was updated to the latest version 0.28.0 and the github action runners were updated to use ubuntu-latest to account for GitHub deprecating the ubuntu-20.04 action runners (see: axodotdev/cargo-dist#1760). This PR is intended to address #132

@brianheineman brianheineman force-pushed the add-aarch64-unknown-linux-gnu branch 2 times, most recently from b98e436 to e930590 Compare May 5, 2025 18:00
Signed-off-by: brianheineman <brian.heineman@gmail.com>
@cdrage
Copy link

cdrage commented Jul 10, 2025

Late to the party, sorry!

@brianheineman could you please remove the AI changes to the file? Such as the quotes / etc.

Makes it easier to review changes that reflect the PR

@brianheineman
Copy link
Author

@cdrage fwiw, I do not believe those are "AI" changes, those changes are the result of running dist init to regenerate the release.yml file:

This file was autogenerated by dist: https://opensource.axo.dev/cargo-dist/

As far as I understand it, that file should not be manually edited, I believe the prescribed approach is to edit the dist-workspace.yml file, then regenerate the release.yml file with dist.

@cdrage
Copy link

cdrage commented Jul 10, 2025

@cdrage fwiw, I do not believe those are "AI" changes, those changes are the result of running dist init to regenerate the release.yml file:

This file was autogenerated by dist: https://opensource.axo.dev/cargo-dist/

As far as I understand it, that file should not be manually edited, I believe the prescribed approach is to edit the dist-workspace.yml file, then regenerate the release.yml file with dist.

Apologizes! I misinterpreted it as https://opensource.axo.dev/cargo-dist/ is a domain squatting site / expired and there were a bunch of quotes / lint changes like you said. So it looked odd to me.

The code LGTM for CI side.

@brianheineman
Copy link
Author

@cdrage The cargo dist project changed recently (funding?) which I believe is why those sites are down. Likely the reason you see all the changes is due to me running with the latest dist version (v0.28.0) at the time the PR was created vs the older version it was originally created with (v0.14.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants