Provider obfuscation in command line #27301
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
added
6.0
baude
removed
the
No New Tests
openshift-ci
bot
added
the
do-not-merge/work-in-progress
For Podman 6, we still have providers and will continue to have a default provider for each platform. But where a platform has multiple providers, we want users to be able to cross provider boudnaries imposed in Podman 4/5. The key change is to look up virtual machines by name, as before, but to then also iterate all possible providers. As of this PR, init will still only create with the default provider, but a subsequent PR will introdouce an provider override. I also removed the "--all-providers" command line option on `podman machine ls` because it no longer makes sense. And I marked the all provider list test to be skipped. Signed-off-by: Brent Baude <bbaude@redhat.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| return nil, nil, &machineDefine.ErrVMDoesNotExist{Name: name} | ||
| } | ||
|
|
||
| func VMExistsOnHyperVisor(name string) (bool, error) { |
There was a problem hiding this comment.
Maybe I'm misunderstanding, but doesn't this function and the VMExists function above do the exact same thing just slightly different?
There was a problem hiding this comment.
VMExistsOnHyperVisor checks with a providers actual hypervisor to see if a VM exists. The VMExists you refer to only checks the providers' local filesystem for machines. Perhaps VMExists could be renamed to MachineExists to clarify in the future ?
There was a problem hiding this comment.
Ah ok, that makes more sense. I think the names are fine, honestly, I just misinterpreted what I was reading
3 participants
For Podman 6, we still have providers and will continue to have a default provider for each platform. But where a platform has multiple providers, we want users to be able to cross provider boudnaries imposed in Podman 4/5. The key change is to look up virtual machines by name, as before, but to then also iterate all possible providers. As of this PR, init will still only create with the default provider, but a subsequent PR will introdouce an provider override.
I also removed the "--all-providers" command line option on
podman machine lsbecause it no longer makes sense.Does this PR introduce a user-facing change?