Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Oct 24, 2025

Description

Pressing the enter key after editing the prompt does not work. This is because the onEnter is used inside useEditor for which the closure does not updated with the latest value. This PR fixes it.

resolves CON-4636

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes Enter key not working after editing the prompt by reading the latest state via refs and correctly handling dropdown focus.

  • Bug Fixes
    • Use isStreamingRef.current to avoid stale closure blocking Enter.
    • Guard Enter when a dropdown is open to prevent unintended actions.

Written for commit 4fc4674. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner October 24, 2025 05:11
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team October 24, 2025 05:11
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 24, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2025
@RomneyDa RomneyDa merged commit 88c11a1 into continuedev:main Oct 30, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
@uinstinct uinstinct deleted the enter-key-input branch October 31, 2025 04:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants