DI: entity mapping can be empty like in nettrine/orm =< v0.9 #122
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ORM DI extension schema to allow the mapping configuration to be empty, restoring compatibility with nettrine/orm versions ≤ 0.9.
- Removed the
requiredand custom assertion enforcing at least one mapping entry. - Adjusted the schema to accept an empty array for
mapping.
Comments suppressed due to low confidence (2)
src/DI/OrmExtension.php:130
- Update the docblock or inline comments above this schema definition to note that
mappingmay now be an empty array, matching legacy behavior.
Expect::string()
src/DI/OrmExtension.php:130
- Add or update a test case to verify that an empty
mappingconfiguration is accepted and does not cause errors at runtime.
Expect::string()
|
bugbot run |
|
???? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #120