comparaison test between JuMP and OptimalControl Models #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Nico77310 Il faut avoir comme tests:
Important De plus, il faudra modifier les modèles OptimalControl pour pouvoir utiliser ExaModels >pour modéliser le NLP obtenu après discrétisation. Dans ce cas, la dynamique doit être donnée par composante. Voir ce problème par exemple. Ajouter un argument nommé ( OptimalControlProblems.jl/ext/OptimalControlModels/beam.jl Lines 5 to 17 in 538d8eb |
Closed
|
@Nico77310 Il faut aussi :
@test list_of_problems_final == available_problems()pour vérifier que la fonction |
Hello @ocots ! For the available_problems function, I implemented a solution using a text file cache that gets written every time you run the tests. This way, you can access the list of available/working problems without having to recompile or re-run the entire test suite. The function reads from this cached file to return the last known working problems list. What do you think about this approach? Do you see any potential improvements or issues with this caching strategy? |
|
I can't push in the branch, can you send me the permission please ? @ocots |
…toolbox/OptimalControlProblems.jl into 78-dev-comparison-tests
|
Hello @ocots, could you review comparison tests between JuMP and OC ? Thank you by advance. |
|
@Nico77310 Je fais une relecture. Je vais faire quelques modifications. Il faut que tu merges la PR #80 |
|
@Nico77310 @antoinepichon03 Voici mes remarques, je fais en fonction du code sur la PR #80.
Note Il faudrait faire ces petits changements pour passer ensuite à l'ajout des modèles avec la dynamique donnée par composante (ce qui est un gros boulot). |
|
@Nico77310 @antoinepichon03 Avez-vous vu mes messages plus haut ? |
Pardon je n'avais pas vu, je regarde ça de suite. |
|
@Nico77310 Attention, il y a pleins de problèmes sans |
|
Todo :
Attention, pour les problèmes sous forme de Lagrange, il faut le pas dans le critère discrétisé : step * sum(u[t]^2 for t in 0:nh) |
|
|
@jbcaillau @PierreMartinon All the init are ok! But for some reason, some objective value are different between JuMP and OptimalControl. I have added the plots of the init in |
|
Test sur solution: |
|
Exemple d'affichage : |
|
@jbcaillau @PierreMartinon @Nico77310 All problems are ok now. All tests pass. I merge! |
|
@PierreMartinon @jbcaillau It is interesting to look at the costate at the first iterate: https://github.com/control-toolbox/OptimalControlProblems.jl/tree/main/test/figures/init. Some are the same and some are not. I mean between OptimalControl and JuMP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.