mantle: detect when dumping to the virtio port failed #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title and description labels are set to the same values but I think the leap from title->summary is greater than the leap from description->summary. Let's use description here.
This will help warn the user that the normal passing of information didn't work right so we can investigate it further. We were seeing this race condition in coreos/fedora-coreos-tracker#2019
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves error reporting in Mantle tests by detecting when journal dumping to the virtio port fails, providing more specific feedback on timeouts. This is a helpful addition for debugging test failures. The change to use org.opencontainers.image.description for the summary in cmd-import is also a good clarification. My review includes a suggestion to improve code clarity in the Go test file.
jlebon
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help warn the user that the normal passing of information
didn't work right so we can investigate it further. We were seeing
this race condition in coreos/fedora-coreos-tracker#2019