kola/multipath: don't race with first-boot-complete.target #4297
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly adds Before=first-boot-complete.target and Wants=first-boot-complete.target to two systemd services that use ConditionFirstBoot=true. This prevents a race condition and ensures they only run on the first boot, as intended. My feedback focuses on improving the accompanying comments to more accurately reflect the changes and systemd best practices, enhancing maintainability.
Anything using ConditionFirstBoot=true really wants Before=first-boot-complete.target too. Otherwise they run the risk of running again on reboot. Likely fixes coreos/rhel-coreos-config#66.
jlebon
force-pushed
the
pr/firstboot-multipath
branch
from
0b4fb7f to
4efc0be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything using ConditionFirstBoot=true really wants Before=first-boot-complete.target too. Otherwise they run the risk of running again on reboot.
Likely fixes coreos/rhel-coreos-config#66.