cmd-coreos-prune: correct barrier release info #4303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adjusts the logic to find barrier releases by looking under the metadata key. It also commendably adds an assertion to validate that barrier release information is present. My review includes a suggestion to enhance the robustness of this new check by replacing the assert statement with a conditional that raises an exception, ensuring the validation is not skipped when the code is run in optimized mode.
The `barrier` key is under the `metadata` dict. Let's update it here and also add an assert to make sure we always get some barrier release info before continuing.
dustymabe
force-pushed
the
dusty-dont-prune-barrier-releases
branch
from
0fc378f to
e18ec13
Compare
jbtrystram
approved these changes
Sep 9, 2025
travier
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
barrierkey is under themetadatadict. Let's update it here and also add an assert to make sure we always get some barrier release info before continuing.