cmd-import: Ignore microseconds in 'created' timestamp label #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the timestamp parsing logic to ignore microseconds, which is a good improvement for compatibility. I've added one suggestion to make the string manipulation for removing fractional seconds more robust and readable by using str.partition() instead of relying on string length and slicing.
PeaceRebel
force-pushed
the
pr/import-timestamp
branch
from
ff89ae0 to
4947322
Compare
jbtrystram
previously approved these changes
Sep 10, 2025
jlebon
reviewed
Sep 10, 2025
jlebon
reviewed
Sep 10, 2025
Not all images includes the timestamp with microseconds. Fixes: coreos#4308
PeaceRebel
force-pushed
the
pr/import-timestamp
branch
from
4947322 to
26d0b34
Compare
jlebon
approved these changes
Sep 11, 2025
|
|
||
| import argparse | ||
| import datetime | ||
| from dateutil import (parser, tz) |
There was a problem hiding this comment.
Minor: parser here is shadowed by parser in parse_args. Not worth the respin, though it's good to avoid shadowing in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all images includes the timestamp with microseconds.
Fixes: #4308