-
Notifications
You must be signed in to change notification settings - Fork 5
Semantic Kernel Tutorial #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @azaddhirajkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, in-depth tutorial designed to help developers build semantic search applications. It focuses on integrating Microsoft's Semantic Kernel with Couchbase's robust vector search features via the Couchbase .NET Vector Store Connector. The tutorial covers the entire process, from setting up the development environment and defining data models to generating embeddings with OpenAI, ingesting data, and executing various vector search queries. It also provides extensive information on configuring different types of Couchbase vector indexes, offering a practical guide for leveraging AI-powered search capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new tutorial for using the Semantic Kernel with Couchbase. The tutorial is comprehensive and well-structured. However, I've found several issues that need to be addressed before merging. There are critical errors in the provided JSON and SQL++ code snippets (missing commas, trailing commas) that will prevent them from working. Additionally, some links point to temporary or internal resources (a feature branch and a test documentation server), which should be updated to stable, public URLs. There are also some invalid tags in the frontmatter that will likely fail validation, and a section on embedding generation is potentially confusing. I've left specific comments with suggestions for each of these points.
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/aspnet/semantic-kernel/semantic-kernel-tutorial.md
Outdated
Show resolved
Hide resolved
nithishr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing. Feel free to fix it & merge.
No description provided.