-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: [Coda] 修复coderunner RCE/SSRF/SQL注入安全漏洞 #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(LogID: 2025091818571901007120218221212EA) Co-Authored-By: Coda <coda@bytedance.com>
|
Codecov Report❌ Patch coverage is
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
return sandbox.NewRunner(config) | ||
default: | ||
return direct.NewRunner() | ||
// 为了安全考虑,移除不安全的direct runner,强制使用sandbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我们不需要移除本地运行方法吧?不然对现有的部分用户来说可能是破坏性的。
只需要将新用户的代码默认运行方式设置为 sandbox 即可,历史用户升级不受影响。
} | ||
|
||
// validateImageURL 验证图片URL的安全性 | ||
validateImageURL := func(urlString string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个貌似不在漏洞修复范围内,暂时不用改?
var err error | ||
|
||
// Handle SQLType: if raw, do not process params | ||
// 禁用原始SQL执行以防止SQL注入攻击 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不能直接禁用,workflow 数据库节点功能依赖这里,通过 env 加个配置让用户判断是否运行直接运行 sql 这样可能好点?
(LogID: 2025091818571901007120218221212EA)
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: