Skip to content

DatePreposition is generating the wrong SQL to find NULL values #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
boblail wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DatePreposition is generating the wrong SQL to find NULL values #14

boblail wants to merge 1 commit into from

Conversation

@boblail
Copy link
Contributor

@boblail boblail commented Feb 9, 2016

I think this is a bug in Arel:

people[:birthday].not_eq(nil) # => "people.birthday IS NOT NULL"
Arel.sql("values.value::date").not_eq(nil) # => "values.value != NULL"

The latter is invalid syntax.

This PR has a failing test, but not a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

archived review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boblail