-
Notifications
You must be signed in to change notification settings - Fork 10
Rename message_base to header for terminology clarity #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: vinniefalco <1503976+vinniefalco@users.noreply.github.com>
Co-authored-by: vinniefalco <1503976+vinniefalco@users.noreply.github.com>
Co-authored-by: vinniefalco <1503976+vinniefalco@users.noreply.github.com>
serializer:: | ||
start( | ||
message_base const& m, | ||
header const& m, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the variable should be renamed from m
to h
, and this should happen everywhere that a message_base
variable is changed to be a header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 6b19f77. Renamed all header const& m
parameters to header const& h
and updated all usages throughout the serializer code.
Co-authored-by: vinniefalco <1503976+vinniefalco@users.noreply.github.com>
Co-authored-by: vinniefalco <1503976+vinniefalco@users.noreply.github.com>
Summary
This PR completes the terminology refactor requested in the issue by renaming
message_base
toheader
throughout the codebase. This clarifies that the class represents the start-line plus fields (the HTTP header), not the full message including body.Changes Made
Files Renamed
include/boost/http_proto/message_base.hpp
→include/boost/http_proto/header.hpp
src/message_base.cpp
→src/header.cpp
test/unit/message_base.cpp
→test/unit/header.cpp
Classes Renamed
class message_base
→class header
Variables Renamed
header const& m
→header const& h
m
→h
where referring to header`m`
→`h`
Updated Files
include/boost/http_proto.hpp
- Updated include directiveinclude/boost/http_proto/fields_base.hpp
- Updated friend declarationinclude/boost/http_proto/request_base.hpp
- Updated base class and constructor callsinclude/boost/http_proto/response_base.hpp
- Updated base class and constructor callsinclude/boost/http_proto/serializer.hpp
- Updated forward declaration, function signatures, and documentationinclude/boost/http_proto/impl/serializer.hpp
- Updated template function parameters and usagessrc/serializer.cpp
- Updated all references to use new class name and variable nametest/unit/metadata.cpp
- Updated test lambdas with new typetest/unit/request.cpp
- Updated include directivedoc/modules/ROOT/pages/reference.adoc
- Updated documentation referenceImpact
This is a breaking change for any code that directly references the
message_base
class. Users will need to update their code to useheader
instead. The change is purely a rename with no functional changes to the API.Verification
message_base
references remain in source code (verified via grep)m
toh
for header parametersOriginal prompt
Fixes #175
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.