-
-
Notifications
You must be signed in to change notification settings - Fork 337
Update PHP 8.5 to RC3, enable swoole-stdext for upcoming 6.1.0 release. #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
bind_textdomain_codeset not being available is due to the HAVE_BIND_TEXTDOMAIN_CODESET feature check failing, therefore the extension doesn't create the function. Unfortunately, this will be super hard to track down with CI only. I can give it a shot on my intel laptop (docker mac) tomorrow. |
… to dynamically check version
| "alt": { | ||
| "type": "ghtagtar", | ||
| "repo": "alisw/GMP" | ||
| "type": "url", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alt will have default value link to https://dl.static-php.dev/static-php-cli/deps/spc-download-mirror/gmp/gmp-spc-mirror.tar.xz if we haven't defined alt.
Also I don't think we need to change it to crawler for gmp. gmplib.org often down and only updated once every few years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll monitor how often it's down over the next weeks. I still think we should auto-updating sources where ever possible.
|
I tried it on multiple local OS, and RC3 also failed almost 100%. Only by changing the dependency order can this problem be fundamentally solved. |
I've already submitted a PR, but that will likely take a while to take effect. The headers should already be generated in the release tarballs from Daniel, we can switch to them. |
This caused by undefined symbol from macOS CoreFoundation and libiconv. I will try it locally. |
|
I need a real mac, my docker version on the intel laptop is so slow that it takes 30 seconds to do a mouse click. Edit: giving up, it's been installing php (finished) & composer (ongoing) for the past hour. |
|
@henderkes Ah I forgot the gmplib.org has banned GitHub IPs for a while. Using gmplib.org is fine for users other than GitHub, but we also rely heavily on GitHub Actions, so can't say it's the best choice. |
What does this PR do?
fixes #943 for some unknown reason
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.