Skip to content

Conversation

@henderkes
Copy link
Collaborator

What does this PR do?

fixes #943 for some unknown reason

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes changed the title Fix/php85 Update PHP 8.5 to RC3, enable swoole-stdext for upcoming 6.1.0 release. Oct 23, 2025
@henderkes henderkes marked this pull request as ready for review October 23, 2025 19:29
@henderkes
Copy link
Collaborator Author

bind_textdomain_codeset not being available is due to the HAVE_BIND_TEXTDOMAIN_CODESET feature check failing, therefore the extension doesn't create the function.

Unfortunately, this will be super hard to track down with CI only. I can give it a shot on my intel laptop (docker mac) tomorrow.

"alt": {
"type": "ghtagtar",
"repo": "alisw/GMP"
"type": "url",
Copy link
Owner

@crazywhalecc crazywhalecc Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt will have default value link to https://dl.static-php.dev/static-php-cli/deps/spc-download-mirror/gmp/gmp-spc-mirror.tar.xz if we haven't defined alt.

Also I don't think we need to change it to crawler for gmp. gmplib.org often down and only updated once every few years.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll monitor how often it's down over the next weeks. I still think we should auto-updating sources where ever possible.

@crazywhalecc
Copy link
Owner

I tried it on multiple local OS, and RC3 also failed almost 100%. Only by changing the dependency order can this problem be fundamentally solved.

@henderkes
Copy link
Collaborator Author

I tried it on multiple local OS, and RC3 also failed almost 100%. Only by changing the dependency order can this problem be fundamentally solved.

I've already submitted a PR, but that will likely take a while to take effect.

The headers should already be generated in the release tarballs from Daniel, we can switch to them.

@crazywhalecc
Copy link
Owner

bind_textdomain_codeset not being available is due to the HAVE_BIND_TEXTDOMAIN_CODESET feature check failing, therefore the extension doesn't create the function.

Unfortunately, this will be super hard to track down with CI only. I can give it a shot on my intel laptop (docker mac) tomorrow.

This caused by undefined symbol from macOS CoreFoundation and libiconv. I will try it locally.

@henderkes
Copy link
Collaborator Author

henderkes commented Oct 24, 2025

I need a real mac, my docker version on the intel laptop is so slow that it takes 30 seconds to do a mouse click.

Edit: giving up, it's been installing php (finished) & composer (ongoing) for the past hour.

@henderkes henderkes merged commit 5476385 into main Oct 24, 2025
5 checks passed
@henderkes henderkes deleted the fix/php85 branch October 24, 2025 10:09
@crazywhalecc
Copy link
Owner

crazywhalecc commented Oct 28, 2025

@henderkes Ah I forgot the gmplib.org has banned GitHub IPs for a while. Using gmplib.org is fine for users other than GitHub, but we also rely heavily on GitHub Actions, so can't say it's the best choice.

https://github.com/static-php/static-php-cli-hosted/actions/runs/18862034099/job/53823388782#step:4:71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.5 build weirdness

3 participants