Revert "Add support for displayName formatting (#144)" #159
Conversation
This reverts commit 54a6fe4.
|
This seems a bit nuclear to me. Can't we just catch that json parsing error and fall back to plain text? If memory serves me right I already did something similar elsewhere. |
| playerDisplayName, | ||
| client.world.getRegistryManager() | ||
| ); | ||
| } catch (JsonParseException exception) { |
There was a problem hiding this comment.
So we already catch JsonParseException here, it seems to me that also catching JsonSyntaxException would likely complete the workaround.
There was a problem hiding this comment.
That would be redundant:
public final class JsonSyntaxException extends JsonParseException
If you'd like to fix it be my guest. But I looked at the code, figured it was already messy and didn't need more branches, didn't want to understand how the text was actually structured, and decided the feature isn't that important. Nobody asked for it and it's never been in a release. |
|
Closing it in favor of the fix here: #163 |
2 participants
This reverts commit 54a6fe4.
Unfixes: #144
With 1.21.9 coming out tomorrow and #148 unresolved I figured I'd revert it as I'm not in the mood for fixing it.