-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix no response / null response from LLM #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vidit-Ostwal
wants to merge
15
commits into
crewAIInc:main
Choose a base branch
from
Vidit-Ostwal:Invalid_response_from_LLM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix no response / null response from LLM #3591
Vidit-Ostwal
wants to merge
15
commits into
crewAIInc:main
from
Vidit-Ostwal:Invalid_response_from_LLM
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @lucasgomide, do you think this could be possible solution for this? I got some feedback from folks who tried the feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a try solution for None / Empty response from LLM.
This PR assumes that this might be because of context length exceeded at the server side, which is not returning an error, just an empty response.
This PR captures the ValueError which is being raised and try again with summarization.
Note
Detect and recover from null/empty LLM responses caused by context-length overflow, while standardizing
messages
toLLMMessage
and adding targeted tests.is_context_length_exceeded(exception, messages, llm)
and addis_null_response_because_context_length_exceeded(...)
to detect empty responses from context overflow; update call sites to passmessages
andllm
.handle_context_length
unchanged behavior but now triggered also on null responses due to context overflow.CrewAgentExecutor
to typemessages
aslist[LLMMessage]
, importLiteral
, and narrow_append_message
role
toLiteral["user","assistant","system"]
; pass new args tois_context_length_exceeded
.messages
type tolist[LLMMessage]
.BaseAgent
instead ofAgent
inTaskEvaluator
andexecute_tool_and_check_finality
signatures.tests/utilities/test_agent_utils.py
coveringis_null_response_because_context_length_exceeded
edge cases.respect_context_window=True
.Written by Cursor Bugbot for commit a3d1666. This will update automatically on new commits. Configure here.