Skip to content

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented May 14, 2025

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe requested a review from a team as a code owner May 14, 2025 11:43
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 34.24%. Comparing base (1a8a95e) to head (65da8a6).

Files with missing lines Patch % Lines
cmd/chain-maind/app/app.go 73.68% 3 Missing and 2 partials โš ๏ธ
app/app.go 87.50% 1 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
+ Coverage   31.75%   34.24%   +2.49%     
==========================================
  Files          93      101       +8     
  Lines       17026    17355     +329     
==========================================
+ Hits         5406     5944     +538     
+ Misses      10678    10457     -221     
- Partials      942      954      +12     
Flag Coverage ฮ”
integration_tests 24.01% <80.00%> (+0.09%) โฌ†๏ธ
integration_tests_byzantine 11.07% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_gov 11.32% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_grpc 11.32% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_ibc 26.61% <80.00%> (+0.09%) โฌ†๏ธ
integration_tests_ledger 11.30% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_slow 11.30% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_solomachine 11.10% <80.00%> (+0.12%) โฌ†๏ธ
integration_tests_upgrade 11.32% <80.00%> (+0.12%) โฌ†๏ธ
unit_tests 11.69% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant