Skip to content

Conversation

gopherorg
Copy link

@gopherorg gopherorg commented Jun 27, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@gopherorg gopherorg requested a review from a team as a code owner June 27, 2025 06:44
@gopherorg gopherorg requested review from XinyuCRO and calvinaco and removed request for a team June 27, 2025 06:44
@songgaoye songgaoye self-requested a review July 12, 2025 13:28
@songgaoye
Copy link
Contributor

@gopherorg Thank you for your contribution. could you rebase main branch and add change log? you also need to to sign your commits.

Signed-off-by: gopherorg <gopherworld@icloud.com>
@gopherorg
Copy link
Author

@gopherorg Thank you for your contribution. could you rebase main branch and add change log? you also need to to sign your commits.

Rebased and signed. And also add Changelog.

Please review again.

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.20%. Comparing base (b1874b6) to head (43fd3d9).

Files with missing lines Patch % Lines
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   31.79%   34.20%   +2.40%     
==========================================
  Files          92      100       +8     
  Lines       17139    17435     +296     
==========================================
+ Hits         5450     5964     +514     
+ Misses      10744    10517     -227     
- Partials      945      954       +9     
Flag Coverage Δ
integration_tests 24.01% <0.00%> (+<0.01%) ⬆️
integration_tests_byzantine 11.13% <0.00%> (+<0.01%) ⬆️
integration_tests_gov 11.38% <0.00%> (+<0.01%) ⬆️
integration_tests_grpc 11.38% <0.00%> (+<0.01%) ⬆️
integration_tests_ibc 26.60% <0.00%> (+<0.01%) ⬆️
integration_tests_ledger 11.36% <0.00%> (+<0.01%) ⬆️
integration_tests_slow 11.36% <0.00%> (+<0.01%) ⬆️
integration_tests_solomachine 11.17% <0.00%> (+<0.01%) ⬆️
integration_tests_upgrade 11.38% <0.00%> (+<0.01%) ⬆️
unit_tests 11.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@songgaoye songgaoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. pending other reviews

@songgaoye songgaoye requested review from JayT106 and thomas-nguy July 24, 2025 05:30
@gopherorg
Copy link
Author

friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants