-
Notifications
You must be signed in to change notification settings - Fork 369
refactor: use maps.Copy for cleaner map handling #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@gopherorg Thank you for your contribution. could you rebase main branch and add change log? you also need to to sign your commits. |
Signed-off-by: gopherorg <gopherworld@icloud.com>
Rebased and signed. And also add Changelog. Please review again. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
+ Coverage 31.79% 34.20% +2.40%
==========================================
Files 92 100 +8
Lines 17139 17435 +296
==========================================
+ Hits 5450 5964 +514
+ Misses 10744 10517 -227
- Partials 945 954 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. pending other reviews
friendly ping |
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)