Removed unnecessary synchronisation #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search.solution was unnecessarily synchronising its operations. The only part where it needs synchronisation is the init part. So, we add a (unsynchronized) check there. This will cause the first call in each thread to try to init, but only one thread will get the lock on CoordCube.class and init it. After this init phase, the process will become completely lock-free(actually this is the double-check idiom)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search.solution was unnecessarily synchronising its operations. The only part where it needs synchronisation is the init part. So, we add a (unsynchronized) check there. This will cause the first call in each thread to try to init, but only one thread will get the lock on CoordCube.class and init it. After this init phase, the process will become completely lock-free(actually this is the double-check idiom)