Refactor to Typescript #92
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriBeck
commented
Jan 19, 2020
|
I can't say much regarding correctness of types, one thing though for sure is that we need flow types as well, since we can't just remove them. Wanna try generate flow types? |
TrySound
reviewed
Jan 26, 2020
TrySound
reviewed
Jan 26, 2020
* master: 3.3.0 Update .size-snapshot.json upgrade flow to 0.131.0, apply prettier 3.2.1 changelog for v3.2.1 Support passing a custom theme type to useTheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the refactor to Typescript.
This includes the following changes
tsdx, therefore a UMD build is not provided anymoreOpen TODOs: