Updated to use latest ndex2 client changes. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Aug 10, 2018
| c1 = CitationElement(id=0, title='Hi') | ||
| cx_network.add_citation(c1) | ||
| c1 = cx_network.add_citation(id=0, title='Hi') | ||
| cx_network.add_edge_citations(e1, c1.get('@id')) |
There was a problem hiding this comment.
The interface would be much more user friendly if it accepted c1 directly, and inside add_edge_citations the code could use isinstance() to check if it's a str or dict, then run this call to get()
There was a problem hiding this comment.
Agreed. I'll update add_edge_citations()
|
Could you update the requirements.txt and setup.py to reflect the different version of the ndex2 package? Side note: The unit testing on this package isn't so good, so I'll have to improve that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are compatible with ndex2-performance version 0.2.0.87+
Once the ndex2 client is fully tested we will merge with the master branch at which time you can install ndex2 (sans "-performance")
be sure to un-install older versions of ndex2 and ndex2-dev before installing
pip install ndex2-performance