Skip to content

Conversation

@PlaidCat
Copy link
Collaborator

This is the first start at a parse and check status of vulns in a PR.

It requires a jira url, user, token, target merge branch and the current branch name. It will look for VULNS in the CIQ header and check their LTS product versus the target branch, if they're in the correct status and if they have any time logged.

It will also make sure that the CVE's commit match the VULNS.

Please see this DRAFT PR for a test example:
ctrliq/kernel-src-tree#615 (comment)

After merging this I will fixup the checkout of this temp branch before submitting this to the each of the branches
ctrliq/kernel-src-tree@487b0da

Note this was all ClaudeCode generated iteratively, locally tested and tested with failure conditions in the above draft PR

@PlaidCat PlaidCat self-assigned this Oct 10, 2025
Copilot AI review requested due to automatic review settings October 10, 2025 01:11
@ciq-it-service-account
Copy link

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a JIRA validation system for checking vulnerability tickets in PR commits. The system validates that VULN tickets have correct status, time logging, LTS product alignment with target branches, and CVE consistency between commits and JIRA tickets.

  • Adds configuration mapping for JIRA fields and product-to-branch relationships
  • Implements comprehensive JIRA ticket validation for vulnerability management
  • Provides detailed error and warning reporting for PR compliance

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
release_config.py Configuration file defining JIRA field mappings and product-to-branch release mappings
jira_pr_check.py Main validation script that parses PR commits, validates VULN tickets against JIRA, and reports compliance issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@roxanan1996
Copy link
Contributor

roxanan1996 commented Oct 10, 2025

At first glance, I would have split the code into some functions for better readability and ease for testing. No time for tests now but we need to do that in the future at some point.

That's also a reason we should use python more instead of bash, in my opinion.

@PlaidCat PlaidCat force-pushed the {jmaple}_pr_jira_test branch from f7311e2 to c88d92b Compare October 20, 2025 22:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This is the first start at a parse and check status of vulns in a PR.

It requires a jira url, user, token, target merge branch and the current
branch name.  It will look for VULNS in the CIQ header and check their
LTS product versus the target branch, if they're in the correct status
and if they have any time logged.
@PlaidCat PlaidCat force-pushed the {jmaple}_pr_jira_test branch from c88d92b to ee1f119 Compare October 20, 2025 22:30
Copy link
Collaborator

@bmastbergen bmastbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥌

@PlaidCat
Copy link
Collaborator Author

LGTM 🥌

Thanks I'm gonna wait until tomorrow afternoon to merge to give other reviewers the chance to object

@roxanan1996
Copy link
Contributor

Ship it. I would personally refactor it, but it can be done later.

@PlaidCat PlaidCat merged commit 23a704c into mainline Oct 24, 2025
@PlaidCat PlaidCat deleted the {jmaple}_pr_jira_test branch October 24, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants