[maximize-kselftest-coverage] firmware: arm_scpi: Ensure scpi_info is not assigned if the probe fails #633
+374
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maximize-kselftest-coverage)
Signed-off-by: Shreeya Patel <spatel@ciq.com>
- Add checkout step with full history (fetch-depth: 0) to enable git operations - Implement intelligent base branch detection: * For PRs: use the base branch directly from github.base_ref * For direct pushes: find closest common ancestor using git merge-base * Iterate through all remote branches to find best match - Compare against detected base branch instead of same branch - Add outputs (comparison_status, comparison_message) for downstream jobs - Improve error handling and warning messages - Skip comparison gracefully if base branch cannot be determined This makes the comparison much more useful by comparing against the branch you're merging into, rather than the previous run of the same branch. Signed-off-by: Shreeya Patel <spatel@ciq.com>
- Create/update PRs automatically when all test stages pass - Include comprehensive test results and build statistics in PR body - Intelligently determine target branch using merge-base - Support both single and multiple commit scenarios - Use helper script to generate well-formatted PR descriptions The PR creation job: - Only runs if build, boot, and kselftest stages succeed - Downloads all artifacts (build logs, boot logs, test logs) - Extracts statistics (test pass/fail counts, build timers) - Determines base branch (same logic as compare-results) - Includes comparison results in PR body - Creates new PR or updates existing one - Adds labels: automated, tested, ready-for-review Files added: - .github/scripts/create-pr-body.sh: Generates PR body with test results - .github/workflows/kernel-build-and-test-x86_64.yml: Adds create-pr job
Signed-off-by: Shreeya Patel <spatel@ciq.com>
Signed-off-by: Shreeya Patel <spatel@ciq.com>
Fixes a bug where scpi_info global variable could be set even when probe fails, leading to potential use-after-free or NULL pointer dereference issues. Changes: - Use local scpi_drvinfo variable during probe - Only assign to global scpi_info after successful initialization - Clear scpi_info if subsequent operations fail - Ensures scpi_info is NULL when driver is not properly initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR has been automatically created after successful completion of all CI stages.
Commit Message(s)
Test Results
✅ Build Stage
✅ Boot Verification
✅ Kernel Selftests
✅ Test Comparison
🤖 This PR was automatically generated by GitHub Actions
Run ID: 18599085108