github-actions: Fix the kselftest comparison logic #762
Conversation
shreeya-patel98
requested review from
PlaidCat,
bmastbergen and
kerneltoast
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes the kselftest comparison logic in the GitHub Actions workflow by replacing the artifact download mechanism. Previously, the workflow attempted to download baseline logs from the base branch directly, but since the CI runs on user branches (not the base branch), this approach was incorrect. The new implementation uses GitHub CLI to search through the last 50 successful workflow runs, identifies runs targeting the same base branch by parsing branch names, and downloads artifacts from the most recent matching run.
Key Changes
- Replaced
dawidd6/action-download-artifact@v11action with custom bash script using GitHub CLI - Added logic to parse branch names and match runs targeting the same base branch using the
{name}_baseor{name}-basepattern - Enhanced error handling and informational messages about baseline availability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shreeya-patel98
force-pushed
the
shreeya_kernelci_main
branch
from
d283915 to
3c0757a
Compare
Previous kselftest comparison was looking for logs in the base branch like ciqlts9_2 but this CI Workflow actually runs on the user branch and not on the base branch so remove the comparison logic and replace it with a new one which uses GH to fetch the successful workflow runs. Signed-off-by: Shreeya Patel <spatel@ciq.com>
shreeya-patel98
force-pushed
the
shreeya_kernelci_main
branch
from
3c0757a to
154af9f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PlaidCat
left a comment
PlaidCat
left a comment
There was a problem hiding this comment.
Thank you for answering my questions
Previous kselftest comparison was looking for logs in the base branch like ciqlts9_2 but this CI Workflow actually runs on the user branch and not on the base branch so remove the comparison logic and replace it with a new one which uses GH to fetch the successful workflow runs.