Skip to content

fix(cubestore): bind to 0.0.0.0 for statsd metrics to be able to send… #9922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cubestore): bind to 0.0.0.0 for statsd metrics to be able to send… #9922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions rust/cubestore/cubestore/src/bin/cubestored.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,7 @@ fn main() {
let metrics_port = std::env::var("CUBESTORE_METRICS_PORT").unwrap_or("8125".to_string());
let metrics_server_address = format!("{}:{}", metrics_addr, metrics_port);

init_metrics(
"127.0.0.1:0",
metrics_server_address,
metrics_format,
vec![],
);
init_metrics("0.0.0.0:0", metrics_server_address, metrics_format, vec![]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FlipEnergy I realized that in some cases exposing metrics via all [public] interfaces might have a security impact. So it would be much better to have this as a controlled option. Let's use an env with the default value of 127.0.0.1 with this. So those who need it (like you) may set the env to the desired value without impacting anyone else.

let telemetry_env = std::env::var("CUBESTORE_TELEMETRY")
.or(std::env::var("CUBEJS_TELEMETRY"))
.unwrap_or("true".to_string());
Expand Down
Loading