-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Oracle use TO_TIMESTAMP_TZ
for ISO 8601 with Z
for date and timestamp
#9970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tankilevitch
wants to merge
7
commits into
cube-js:master
Choose a base branch
from
Tankilevitch:fix-schema-compiler-oracle-timestamp-iso8601
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(schema-compiler): Oracle use TO_TIMESTAMP_TZ
for ISO 8601 with Z
for date and timestamp
#9970
Tankilevitch
wants to merge
7
commits into
cube-js:master
from
Tankilevitch:fix-schema-compiler-oracle-timestamp-iso8601
+60
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex-friendly casts; add Oracle unit test
TO_TIMESTAMP_TZ
for ISO 8601 with Z
for date and timestamp
Hi @Tankilevitch! Thank you for your contribution! And the test you added is also failing:
Please ping me when you push an update so I can trigger a workflow run. |
…ema-compiler-oracle-timestamp-iso8601
…ema-compiler-oracle-timestamp-iso8601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data source driver
driver:oracle
Issues relating to the Oracle driver
pr:community
Contribution from Cube.js community members.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
fixes #9971
Bug: Oracle timestamp parsing mismatch (TO_DATE vs ISO string with .000Z)
Summary
Cube generates an Oracle query using TO_DATE with a format mask that does not match the actual ISO-8601 timestamp emitted by the backend (2024-02-01T00:00:00.000Z). This causes Oracle errors, while Postgres accepts the same value.
Input Query
Generated SQL (Oracle)
Bind value passed
Problem
The format
'YYYY-MM-DD"T"HH24:MI:SS"Z"'
does not handle:Fractional seconds(.000)
Oracle raises ORA-01821: date format not recognized.
Expected behavior
Oracle should parse the backend’s ISO string correctly, including fractional seconds and UTC Z.
Suggested fix
Use
TO_TIMESTAMP_TZ
with a matching format mask:to_timestamp_tz(:"?", 'YYYY-MM-DD"T"HH24:MI:SS.FF"Z"')
and
CAST(TO_TIMESTAMP_TZ(:"?", 'YYYY-MM-DD"T"HH24:MI:SS.FF"Z"') AS DATE)
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]
-->