-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(api-gateway): Introduce cache mode option for /cubesql
API
#9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9972 +/- ##
==========================================
- Coverage 77.13% 77.11% -0.02%
==========================================
Files 440 440
Lines 89307 89348 +41
Branches 3101 3108 +7
==========================================
+ Hits 68889 68905 +16
- Misses 20029 20051 +22
- Partials 389 392 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bb98d78
to
2c625cf
Compare
@KSDaemon Should we document what each option is supposed to do in the code? I feel like it might get lost in Jira/docs at some point 😄 |
Well, why not... |
e2f1742
to
b53ae15
Compare
00b37ce
to
c04b566
Compare
…types) # Conflicts: # packages/cubejs-api-gateway/package.json # Conflicts: # packages/cubejs-api-gateway/package.json # Conflicts: # packages/cubejs-api-gateway/package.json # Conflicts: # packages/cubejs-api-gateway/package.json
c04b566
to
e097eb9
Compare
Check List