Add preliminary support for rendering run hooks #408
Conversation
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks for doing this. Looks good, but some fairly minor feedback and suggestions.
I noticed on the story for BeforeAll errors that the <FilteredDocuments> component renders "nothing found" when really there are just no test cases at all - I'm reworking the search/filtering behaviour on another branch so I'll aim to take care of this over there, but I'm glad this change shone a light on it.
|
|
||
| export const RunHooksList: FunctionComponent<{ children: ReactNode }> = ({ children }) => { | ||
| return ( | ||
| <ol aria-label="RunHooks" className={styles.hooks}> |
There was a problem hiding this comment.
I'd leave it to consumers to decide if/how to label this section with e.g. headings.
There was a problem hiding this comment.
How were you thinking? EG. a aria-label prop?
There was a problem hiding this comment.
I would envisage more like a consumer doing:
return <>
<h2>Hooks!</h2>
<TestRunHooks/>
</>So I think it's fine to just do nothing here.
There was a problem hiding this comment.
Do you think such heading such be conditionally rendered in @cucumber/html-formatter based on existence of test run hooks?
There was a problem hiding this comment.
Alternatively, the list itself can render something like No hooks found, or similar.
There was a problem hiding this comment.
Alternatively, the list itself can render something like No hooks found, or similar.
Yeah, I think that would work.
Leave this to the consumer.
This served little to no purpose.
This may be used by consumers of <TestRunHooks /> to eg. conditionally render a heading.
🤔 What's changed?
A list below GherkinDocument, showing
BeforeAll(..)andAfterAll(..)hooks.⚡️ What's your motivation?
Errors in
BeforeAll(..)leads to a merely empty document - this shows why, in addition to adding support for presenting run hooks attachments.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Anything, really. I'm new to the project and even ladle.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.