-
Notifications
You must be signed in to change notification settings - Fork 1
External repos #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
there are two |
|
there should probably a |
|
It might be ok to push this into a later PR, but we should think about detecting if a user is trying something stupid by first creating a store with repository a, and then adding a package from repository b whose definition is incompatible with the packages from a. This might cut further into the question of how versioning of packages is done (with semantics of ID X of package a is newer than ID y) |
|
Last point, I would be in favour of moving the repo from dpm/repo to something like default_repo in the project top-level to make the weak coupling more apparent. While keeping it completely separate would be the ideologically nicest way, cloning two repos just seems like a hassle. |
I keep them separate for my self, as I do not want to pollute the main repo with my system specific changes. However, I do like the idea of having a "default" repo. It might be reasonable to use a subrepo here.
I do agree, but I would indeed do this in a later PR. |
sounds reasonable. Question is: Who gets the lead? E.g. who manages the solver? |
|
done. |
|
|
Also pls rebase, because I hacked together something like a CI |
|
I'm getting this error currently ~/sw/dpm % ./dpm.py help
Traceback (most recent call last):
File "/home/cvonelm/sw/dpm/./dpm.py", line 8, in <module>
import dpm.pkg_definition
File "/home/cvonelm/sw/dpm/dpm/pkg_definition/__init__.py", line 2, in <module>
from .recipe import BasePackageRecipe as BasePackageRecipe
File "/home/cvonelm/sw/dpm/dpm/pkg_definition/recipe.py", line 11, in <module>
from dpm.downloader import Resource
File "/home/cvonelm/sw/dpm/dpm/downloader/__init__.py", line 4, in <module>
from .git import Git as Git
File "/home/cvonelm/sw/dpm/dpm/downloader/git.py", line 6, in <module>
from dpm.types import Needs
File "/home/cvonelm/sw/dpm/dpm/types/__init__.py", line 5, in <module>
import dpm.repo
File "/home/cvonelm/sw/dpm/dpm/repo/__init__.py", line 7, in <module>
from dpm.types import Package
ImportError: cannot import name 'Package' from partially initialized module 'dpm.types' (most likely due to a circular import) (/home/cvonelm/sw/dpm/dpm/types/__init__.py) |
This PR adds the option to Install packages from external repos